Skip to content

Commit

Permalink
src: avoid cloning
Browse files Browse the repository at this point in the history
  • Loading branch information
joaoantoniocardoso committed Sep 17, 2024
1 parent f2971a0 commit ef36da3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 1 addition & 3 deletions src/device/manager/continuous_mode.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ impl DeviceManager {
device_type: DeviceSelection,
) -> Option<tokio::task::JoinHandle<()>> {
let raw_handler = match self.get_device_handler(device_id).await {
Ok(handler) => handler.clone(),
Ok(handler) => handler,
Err(err) => {
trace!("Error during start_continuous_mode: Failed to get device handler: {err:?}");
return None;
Expand Down Expand Up @@ -49,8 +49,6 @@ impl DeviceManager {
})),
DeviceSelection::Ping360 => {
Some(tokio::spawn(async move {
let handler = handler.clone();

// Attempt to send the Ping360 request and handle the result
let device_data = match handler
.send(crate::device::devices::PingRequest::Ping360(
Expand Down
8 changes: 5 additions & 3 deletions src/server/protocols/v1/websocket.rs
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,13 @@ pub async fn websocket(
stream: web::Payload,
manager_handler: web::Data<ManagerActorHandler>,
) -> Result<HttpResponse, actix_web::Error> {
let filter = match query.clone().into_inner().filter {
Some(filter) => filter.clone(),
let query_inner = query.into_inner();

let filter = match query_inner.filter {
Some(filter) => filter,
_ => ".*".to_owned(),
};
let device_number = query.into_inner().device_number;
let device_number = query_inner.device_number;

if let Some(device_number) = device_number {
let request = crate::device::manager::Request::Info(crate::device::manager::UuidWrapper {
Expand Down

0 comments on commit ef36da3

Please sign in to comment.