Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Thruster Nodes #41

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Jan 18, 2021

This makes assembling rovs a little more intuitive, as the position and directions of the thrusters can be better visualized in the editor.

image

This also spits out a motors Matrix:

motors.matrix.mp4

@patrickelectric
Copy link
Member

Is it possible somehow to display the motor rotation as cw or ccw ?

@Williangalvani
Copy link
Member Author

Is it possible somehow to display the motor rotation as cw or ccw ?

I intend to rave an arc around it for the direction of the propeller and counter-torque eventually, but we don't simulate that yet

@patrickelectric
Copy link
Member

for reference: #43

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From godot:
image

image

Tested with 38abf05

@Williangalvani
Copy link
Member Author

that is odd, did you checkout with godot open? it doesn't like it very much

@patrickelectric
Copy link
Member

that is odd, did you checkout with godot open? it doesn't like it very much

It's still failing to load but the first error message does not exist, not sure what exactly happening.

image

image

@Williangalvani
Copy link
Member Author

@patrickelectric do you mind trying this again? I can't replicate your issue. Are you on Godot 3.2.3 ?

@patrickelectric
Copy link
Member

patrickelectric commented Feb 23, 2021

@Williangalvani the file does not exist
image
image
image

@patrickelectric patrickelectric merged commit 7ead16a into bluerobotics:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants