Update: Add css var to wallet icons to allow for setting a contract color where applicable #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
leightkt
approved these changes
Jun 30, 2023
|
Not necessary for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add css var to wallet icons to allow for setting a contract color where applicable.
This issue arose from some wallet icons disappearing if the text color is set to the same color as the background of the wallet icon containers within the select wallet modal.
Adding a contrast var:
--onboard-wallet-icon-contrast-colorthat takes precedent allows devs to fix this issue without any side affects.If the color is hardcoded it can also be lost or hard to see with dark or light background.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errors