-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add option to hide the where is my wallet notice #1786
fix: Add option to hide the where is my wallet notice #1786
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Adamj1232 we are currently patching this on our side. Anything I can do to move this PR forward? |
@usame-algan thanks for this PR - I am discussing supporting this with the team and will update shortly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@usame-algan thank you for the PR!
I tested locally and works as expected. Added some test code, enhanced docs and formatted. Will merge after CI checks finalize!
undefined. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @web3-onboard/[email protected], @web3-onboard/[email protected] |
Description
Adds an option to hide the "Where is my wallet" notice
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errorsDocs Checklist
docs/package.json
file (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Tests with demo app (injected)
Tests with demo app (SDK)