Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add option to hide the where is my wallet notice #1786

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

usame-algan
Copy link
Contributor

@usame-algan usame-algan commented Jun 27, 2023

Description

Adds an option to hide the "Where is my wallet" notice

Screenshot 2023-06-27 at 11 25 03

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 2:33pm

Copy link
Contributor

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@usame-algan
Copy link
Contributor Author

@Adamj1232 we are currently patching this on our side. Anything I can do to move this PR forward?

@Adamj1232
Copy link
Member

@usame-algan thanks for this PR - I am discussing supporting this with the team and will update shortly!
In the mean time can you bump the alpha version within the version tag(x.x.x-alpha.x the final x) of packages/core/package.json when you have a moment?

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usame-algan thank you for the PR!
I tested locally and works as expected. Added some test code, enhanced docs and formatted. Will merge after CI checks finalize!

@socket-security
Copy link

undefined. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @web3-onboard/[email protected], @web3-onboard/[email protected]

@Adamj1232 Adamj1232 merged commit bda3475 into blocknative:develop Jun 29, 2023
3 checks passed
This was referenced Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants