-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metaswap and pooled staking events #717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to double check if you did the file names / table_names like this on purpose because it's usually camel cased.
} | ||
], | ||
"table_description": "", | ||
"table_name": "metamask_swaps_v1_event_AdapterRemoved" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the table_name
, we usually camel case this (ie, in this case Metamask_Swaps_V1_event_AdapterRemoved
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no I can change this, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, should have been more clear. Naming also applies to the pooled staking events as well. So something like Pooled_Staking_event_Deposited
.
Also currently the CI/CD is failing because the file name doesn't match the table name.
Usually the v1
is actually lower cased (example would be AToken_v3_event_Approval
Ah, gotcha @kome12! Thanks. I'll revise the whole thing then. |
Still a bit confused on the validate-json-files error... |
Sorry about that, it's a bit confusing because I'm asking you to change quite a few things. It's failing right now because the file name doesn't match with the table name. So if you changed the table name to be |
What?
How?
Related PRs (optional)
n/a
Anything Else?
n/a