Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added arbitrum uniswap v3 factory and pools events, removed arbitrum uniswap factory nft events #688

Merged
merged 11 commits into from
May 12, 2024

Conversation

liordavid
Copy link
Contributor

What?

added arbitrum uniswap v3 factory and pools events, removed arbitrum uniswap factory nft events

How?

ie: I used abi-parser or cli tools to build the table definitions

@medvedev1088
Copy link
Member

What does "_open" suffix in the dataset name mean? Would it make sense to have "arbitrum_uniswap_v3" dataset instead of having separate "arbitrum_uniswap_v3_nft_positions" and "arbitrum_uniswap_v3_open"?

@liordavid
Copy link
Contributor Author

I deleted arbitrum_uniswap_v3_nft_positions as it is not needed.
In general, the purpose is to have log events of mint, burn and swap.
I will remove the "_open" and change it to "arbitrum_uniswap_v3".

@liordavid liordavid closed this May 12, 2024
@liordavid liordavid reopened this May 12, 2024
@liordavid
Copy link
Contributor Author

Hi medvedev1088, I fixed this dataset name as we discussed. will be glad for your review.

@medvedev1088 medvedev1088 merged commit 6945ab4 into blockchain-etl:master May 12, 2024
3 checks passed
@liordavid
Copy link
Contributor Author

liordavid commented May 20, 2024

hi @medvedev1088 , i expected this commit to creating a dataset on big query with arbitrum date coming from log events of the contract I put in the JSON files. in practice, the same contract address also exists in Ethereum main net and the data I see in the tables is the Ethereum main net events, how and where do I specify the network to work with? Is it some definition on the JSON files or in the airflow project? I see some of the datasets work with layer 2 networks? can you please refer me to an article or guidance on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants