[nrf fromlist] modules: hostap: Use net_mgmt context

Using a separate workqueue causes issues without any special locking to synchronize with networking threads e.g., interface being removed while the workqueue is trying to synchronize with WPA supplicant. It's easier to use the net_mgmt thread which is in better sync with networking. Upstream PR: zephyrproject-rtos/zephyr#79231 Signed-off-by: Chaitanya Tata <[email protected]>
bjarki-andreasen · Oct 1, 2024 · 8ad93ce · 8ad93ce
1 parent d42f4be
commit 8ad93ce
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/modules/hostap/src/supp_main.c b/modules/hostap/src/supp_main.c
@@ -475,9 +475,6 @@ static void submit_iface_work(struct supplicant_context *ctx,
 static void interface_handler(struct net_mgmt_event_callback *cb,
 			      uint32_t mgmt_event, struct net_if *iface)
 {
-	struct supplicant_context *ctx = CONTAINER_OF(cb, struct supplicant_context,
-						      cb);
-
 	if ((mgmt_event & INTERFACE_EVENT_MASK) != mgmt_event) {
 		return;
 	}
@@ -490,13 +487,13 @@ static void interface_handler(struct net_mgmt_event_callback *cb,
 
 	if (mgmt_event == NET_EVENT_IF_ADMIN_UP) {
 		LOG_INF("Network interface %d (%p) up", net_if_get_by_iface(iface), iface);
-		submit_iface_work(ctx, iface, add_interface);
+		add_interface(get_default_context(), iface);
 		return;
 	}
 
 	if (mgmt_event == NET_EVENT_IF_ADMIN_DOWN) {
 		LOG_INF("Network interface %d (%p) down", net_if_get_by_iface(iface), iface);
-		submit_iface_work(ctx, iface, del_interface);
+		del_interface(get_default_context(), iface);
 		return;
 	}
 }