Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth/PM-11969 - Registration with Email Verification - Accept Emergency Access Invite Flow #4773

Conversation

JaredSnider-Bitwarden
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden commented Sep 12, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11969
Clients PR: bitwarden/clients#11018

📔 Objective

To add support for the accept emergency access invite flow in the new registration with email verification flow.

📸 Screenshots

See clients PR.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@JaredSnider-Bitwarden JaredSnider-Bitwarden changed the title Auth/pm 11969/emergency access invite broken in registration w email verification Auth/PM-11969 - Registration with Email Verification - Accept Emergency Access Invite Flow Sep 12, 2024
@JaredSnider-Bitwarden JaredSnider-Bitwarden marked this pull request as ready for review September 12, 2024 21:59
@JaredSnider-Bitwarden JaredSnider-Bitwarden requested a review from a team as a code owner September 12, 2024 21:59
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.80%. Comparing base (7d8df76) to head (35ee952).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Identity/Controllers/AccountsController.cs 72.72% 2 Missing and 1 partial ⚠️
...egistration/Implementations/RegisterUserCommand.cs 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4773      +/-   ##
==========================================
+ Coverage   41.76%   41.80%   +0.03%     
==========================================
  Files        1308     1308              
  Lines       62013    62046      +33     
  Branches     5710     5714       +4     
==========================================
+ Hits        25899    25936      +37     
+ Misses      34923    34916       -7     
- Partials     1191     1194       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details11b81981-b3d6-4de9-b850-28967d098c8c

No New Or Fixed Issues Found

@JaredSnider-Bitwarden JaredSnider-Bitwarden merged commit fd07de7 into main Sep 12, 2024
51 checks passed
@JaredSnider-Bitwarden JaredSnider-Bitwarden deleted the auth/pm-11969/emergency-access-invite-broken-in-registration-w-email-verification branch September 12, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants