Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IP API response #4771

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Remove IP API response #4771

merged 1 commit into from
Sep 12, 2024

Conversation

withinfocus
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12032

📔 Objective

Removes a method we no longer use that reveals internal information.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review September 12, 2024 18:39
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.70%. Comparing base (97795de) to head (5a5c601).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4771   +/-   ##
=======================================
  Coverage   41.70%   41.70%           
=======================================
  Files        1308     1308           
  Lines       61987    61984    -3     
  Branches     5708     5707    -1     
=======================================
  Hits        25852    25852           
+ Misses      34944    34941    -3     
  Partials     1191     1191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details6c8e38d4-2702-4743-bcd3-113f5f04ca1b

No New Or Fixed Issues Found

@withinfocus withinfocus merged commit 95ba256 into main Sep 12, 2024
51 checks passed
@withinfocus withinfocus deleted the remove-ip branch September 12, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants