PM-11123: Device Type mapping

[mzieniukbw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11123

📔 Objective

Device Types mappings.
(Split from #4741)

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.72%. Comparing base (c839280) to head (e77bdce).

Files with missing lines	Patch %	Lines
src/Core/Utilities/DeviceTypes.cs	92.85%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4768      +/-   ##
==========================================
+ Coverage   41.70%   41.72%   +0.01%     
==========================================
  Files        1308     1308              
  Lines       61983    62003      +20     
  Branches     5707     5707              
==========================================
+ Hits        25852    25870      +18     
- Misses      34940    34942       +2     
  Partials     1191     1191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 6817f27c-958c-478f-bd49-5711a06b03a4

No New Or Fixed Issues Found

[withinfocus]

I see the DeviceTypeToClientType method in your other PR being useful here. The client type can be lifted out of the NotificationCenter namespace as well, and then the other classes we spoke about being cleaned up too.

[mzieniukbw]

@withinfocus i wanted to create a follow up PR once this is done with the unification of Client Types and mapping, but i can fit it into one PR too.

[withinfocus]

Whatever is easiest. That one method is something I will use for https://bitwarden.atlassian.net/browse/PM-11984.