[PM-336] Enable Nullable In Unowned Services

[justindbaur]

🎟️ Tracking

📔 Objective

Enable nullable in un-owned services in the Core project. I made changes to have as little impact to business logic as possible.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 22.09302% with 67 lines in your changes missing coverage. Please review.

Project coverage is 41.82%. Comparing base (ebf8bc0) to head (050b7bf).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...e/Services/Implementations/StripePaymentService.cs	22.85%	27 Missing ⚠️
src/Core/Services/Implementations/UserService.cs	14.28%	17 Missing and 1 partial ⚠️
...tityFramework/Repositories/CollectionRepository.cs	0.00%	6 Missing ⚠️
src/Core/Models/PushNotification.cs	0.00%	3 Missing ⚠️
...vices/Implementations/BaseIdentityClientService.cs	62.50%	2 Missing and 1 partial ⚠️
...Core/Services/Implementations/I18nViewLocalizer.cs	0.00%	3 Missing ⚠️
src/Core/Services/Implementations/I18nService.cs	0.00%	2 Missing ⚠️
...rvices/NoopImplementations/NoopLicensingService.cs	0.00%	2 Missing ⚠️
...Core/Services/Implementations/CollectionService.cs	0.00%	1 Missing ⚠️
.../Services/Implementations/HandlebarsMailService.cs	66.66%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #4748    +/-   ##
========================================
  Coverage   41.82%   41.82%            
========================================
  Files        1293     1294     +1     
  Lines       61632    61750   +118     
  Branches     5681     5696    +15     
========================================
+ Hits        25778    25829    +51     
- Misses      34664    34730    +66     
- Partials     1190     1191     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coroiu]

Ouf 58 files. I'm just gonna approve and assume that the compiler knows what it's doing

[github-actions]

Checkmarx One – Scan Summary & Details – f25cc1ec-c804-4252-98d3-c847986c2ad0

No New Or Fixed Issues Found