Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11667] Remove all code related to the outdated custom permissions 'Edit/Delete Assigned Collections' #4736

Merged

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Sep 5, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11667

📔 Objective

Remove all code related to the outdated custom permissions 'Edit/Delete Assigned Collections'.

Clients PR.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.73%. Comparing base (4c0f8d5) to head (86ca7d7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4736      +/-   ##
==========================================
- Coverage   41.76%   41.73%   -0.03%     
==========================================
  Files        1305     1304       -1     
  Lines       61944    61824     -120     
  Branches     5703     5692      -11     
==========================================
- Hits        25868    25804      -64     
+ Misses      34885    34832      -53     
+ Partials     1191     1188       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Logo
Checkmarx One – Scan Summary & Details88dd23b4-8917-4843-9d59-49c448768173

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /src/Api/Controllers/DevicesController.cs: 133 Attack Vector
MEDIUM Privacy_Violation /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 259 Attack Vector
MEDIUM Privacy_Violation /src/Api/Controllers/DevicesController.cs: 159 Attack Vector
MEDIUM Privacy_Violation /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 350 Attack Vector
MEDIUM Privacy_Violation /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 403 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
LOW Log_Forging /src/Api/Controllers/DevicesController.cs: 124 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 239 Attack Vector
LOW Log_Forging /src/Api/Controllers/DevicesController.cs: 150 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 315 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 378 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 74
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 61
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 478
MEDIUM CSRF /src/Api/Billing/Public/Controllers/OrganizationController.cs: 47
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 176
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 445
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 551
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 565
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 478
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 283
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 503
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 74
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 61
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 118

Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@r-tome r-tome merged commit add8783 into main Sep 10, 2024
53 checks passed
@r-tome r-tome deleted the ac/pm-11667/deprecated-custom-permissions-delete-code-definitions branch September 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants