Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10321/PM-10322] Add Endpoints for Deleting Single and Multiple Organization-Managed Users #4727

Open
wants to merge 5 commits into
base: ac/pm-10316/add-ideletemanagedorganizationuseraccountcommand
Choose a base branch
from

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Sep 3, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10321
https://bitwarden.atlassian.net/browse/PM-10322

📔 Objective

This pull request introduces two new endpoints for managing the deletion of organization-managed users:

  1. Single User Deletion Endpoint {id}/delete-account: Allows for the removal and data deletion of an individual user identified by organizationUserId within a specified organization (organizationId).
  2. Bulk User Deletion Endpoint /delete-account: Provides functionality to remove multiple users and delete their associated data in one operation, given a list of organizationUserIds for a specified organization (organizationId).

Both endpoints leverage the new command created on #4726

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@r-tome r-tome marked this pull request as ready for review September 3, 2024 15:00
@r-tome r-tome requested a review from a team as a code owner September 3, 2024 15:00
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.82%. Comparing base (c147f11) to head (cef4d9a).

Additional details and impacted files
@@                                       Coverage Diff                                        @@
##           ac/pm-10316/add-ideletemanagedorganizationuseraccountcommand    #4727      +/-   ##
================================================================================================
+ Coverage                                                         41.78%   41.82%   +0.04%     
================================================================================================
  Files                                                              1290     1291       +1     
  Lines                                                             61174    61207      +33     
  Branches                                                           5638     5644       +6     
================================================================================================
+ Hits                                                              25562    25602      +40     
+ Misses                                                            34409    34402       -7     
  Partials                                                           1203     1203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Logo
Checkmarx One – Scan Summary & Detailscff5b554-8183-4724-a3d5-5eb9a480c477

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 546 Attack Vector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants