[PM-10311] Account Management: Create helper methods for checking against verified domains #4636
Conversation
…rRepository and the corresponding queries
…ng-against-verified-domains
|
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4636 +/- ##
==========================================
- Coverage 41.74% 41.73% -0.02%
==========================================
Files 1304 1306 +2
Lines 61841 61923 +82
Branches 5694 5697 +3
==========================================
+ Hits 25818 25845 +27
- Misses 34835 34890 +55
Partials 1188 1188 ☔ View full report in Codecov by Sentry. |
…tionAsync to GetManyIdsManagedByOrganizationIdAsync
…ng-against-verified-domains
…ationService.GetUsersOrganizationManagementStatusAsync
…verified-domains' of https://github.com/bitwarden/server into ac/pm-10311/create-helper-methods-for-checking-against-verified-domains
…nc to return IDictionary<Guid, bool>
…ng-against-verified-domains
| /// <summary> | ||
| /// Indicates if the organization has any verified domains. | ||
| /// </summary> | ||
| Task<bool> HasVerifiedDomainsAsync(Guid orgId); |
There was a problem hiding this comment.
Should OrganizationDomainService be in the AdminConsole folder for code ownership purposes? We can move it without changing the namespace to avoid breaking imports if there are a lot of them, but while we're here it makes sense to move it if this a part of ACs domain.
There was a problem hiding this comment.
I moved the namespace, there were only two references.
…ng-against-verified-domains
|
(But please get @addisonbeck's final review) |
| { | ||
| // Users can only be managed by an Organization that is enabled and can have organization domains | ||
| var organizationAbility = await _applicationCacheService.GetOrganizationAbilityAsync(organizationId); | ||
| if (organizationAbility is { Enabled: true, UseSso: true }) |
There was a problem hiding this comment.
Since we've identified that UseSso is not very apt here and are going to improve this as tech debt: lets add a comment here indicating that UseSso is used to signify that the organization has access to domain verification. Bonus points if it includes a link to a Jira ticket.
There was a problem hiding this comment.
I said I'd follow this up, so I've created a ticket for it here that you can link to: https://bitwarden.atlassian.net/browse/PM-11622
…ng-against-verified-domains
…verified domain checks
…ng-against-verified-domains # Conflicts: # src/Core/OrganizationFeatures/OrganizationServiceCollectionExtensions.cs
…ng-against-verified-domains
…ng-against-verified-domains
r-tome
deleted the
ac/pm-10311/create-helper-methods-for-checking-against-verified-domains
branch
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10311
📔 Objective
The Account Management MVP will introduce managed and unmanaged members. This PR aims to add server methods to identify managed users.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes