Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow acceptable result ranges for integration tests #3161

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

MGibson1
Copy link
Member

@MGibson1 MGibson1 commented Aug 7, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

I've had issues with this test https://github.com/bitwarden/server/runs/15556068099#r6. It seems to me like what we're really interested in is blocking requests at about this frequency, and slightly faster or slower is OK.

I also changed the number of requests. Comments says it's limited to 10/sec. It seemed like 10 requests was a safer value

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailsf50ca2b2-a1eb-419c-96cd-0ee47f089b0c

No New Or Fixed Issues Found

Copy link

@nsbgit nsbgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MGibson1 MGibson1 merged commit ca36846 into master Aug 8, 2023
43 checks passed
@MGibson1 MGibson1 deleted the fix-flaky-integration-test branch August 8, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants