Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-1418] Add SecretsManagerPlan property to OrganizationResponseModel #3055

Merged
merged 1 commit into from
Jul 3, 2023
Merged

[AC-1418] Add SecretsManagerPlan property to OrganizationResponseModel #3055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Api/Models/Response/Organizations/OrganizationResponseModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public OrganizationResponseModel(Organization organization, string obj = "organi
BusinessTaxNumber = organization.BusinessTaxNumber;
BillingEmail = organization.BillingEmail;
Plan = new PlanResponseModel(StaticStore.PasswordManagerPlans.FirstOrDefault(plan => plan.Type == organization.PlanType));
SecretsManagerPlan = new PlanResponseModel(StaticStore.SecretManagerPlans.FirstOrDefault(plan => plan.Type == organization.PlanType));
PlanType = organization.PlanType;
Seats = organization.Seats;
MaxAutoscaleSeats = organization.MaxAutoscaleSeats;
Expand Down Expand Up @@ -65,6 +66,7 @@ public OrganizationResponseModel(Organization organization, string obj = "organi
public string BusinessTaxNumber { get; set; }
public string BillingEmail { get; set; }
public PlanResponseModel Plan { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Should we create a tech debt ticket to update this property name to PasswordManagerPlan?

Copy link
Member

@eliykat eliykat Jul 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of. These plan objects need refactoring generally - I think we'll probably end up combining them, imo we should have an "Enterprise Plan" which contains different possible products, not a "PM plan" and an "SM plan". This is tracked in AC-1451 to be done immediately after GA. I'll update the description in Jira.

That would also resolve your concern here because we'll go back to having a single plan, which is why I haven't pushed renaming everything just yet.

public PlanResponseModel SecretsManagerPlan { get; set; }
public PlanType PlanType { get; set; }
public int? Seats { get; set; }
public int? MaxAutoscaleSeats { get; set; } = null;
Expand Down
Loading