Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application to populate secret manager data for testing #1068

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

MGibson1
Copy link
Member

📔 Objective

This is a system for setup and tear down of projects and secrets for testing language bindings.

Usage is intended to be through bws run targeting the QA server. I have set up an organization and project there. This project is useful for parsing a json representation of common projects and secrets for language tests. Each language should parse this same setting and add RUN_ID in the same way.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 18, 2024

Logo
Checkmarx One – Scan Summary & Details030ee31b-f445-4c0a-95b3-bfc03666206a

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 41 Attack Vector
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 40 Attack Vector
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 56 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 341 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /languages/java/example/Example.java: 46
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/example/Example.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 138
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 41
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 41
MEDIUM Privacy_Violation /languages/java/example/Example.java: 53
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 20
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 124
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 58
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 131
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 338
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 173
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 198
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 86
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 66
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 54
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 192
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 61
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 43

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 304 lines in your changes missing coverage. Please review.

Project coverage is 56.88%. Comparing base (b00d337) to head (a4b9ff3).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
languages/language_tests/src/main.rs 0.00% 236 Missing ⚠️
languages/language_tests/src/e2e_data.rs 0.00% 67 Missing ⚠️
...rates/bitwarden-core/src/client/client_settings.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
- Coverage   58.18%   56.88%   -1.31%     
==========================================
  Files         197      199       +2     
  Lines       13486    13826     +340     
==========================================
+ Hits         7847     7865      +18     
- Misses       5639     5961     +322     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MGibson1 MGibson1 force-pushed the sm/language-binding-test-setup branch from dff46b6 to d59a87e Compare September 18, 2024 19:58
@MGibson1 MGibson1 force-pushed the sm/language-binding-test-setup branch from 0509ed6 to a4b9ff3 Compare September 19, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant