Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes nonce errors conclusive #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SethMcGuire
Copy link
Contributor

No description provided.

@@ -250,7 +250,12 @@ class EthRPC {
.sendSignedTransaction(rawTx)
.once('transactionHash', resolve)
.once('error', reject)
.catch(err => reject(err));
.catch((err) => {
if (err.message.includes('nonce')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe overkill, but could we be a bit more defensive and check for err.message as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants