Extend API

[martinstark]

Adds the following:

• Ability to fetch the current timestamp including stitched ad durations when viewing VODs. CAUTION: this timestamp may refer to different relative positions on each video start, depending on length of stitched ads
• Ability to fetch the duration including stitched ad durations when viewing VODs. CAUTION: this timestamp may refer to different relative positions on each video start, depending on length of stitched ads

to test, call:

player.getCurrentTime(TimeMode.AbsoluteTime);
player.getDuration(TimeMode.AbsoluteTime);

If the player is currently playing an ad, by default, the methods would return the position within the ad and the duration of the ad respectively. If the TimeMode.AbsoluteTime parameter is added, the methods will instead return the absolute time, ignoring ongoing ads.

[dweinber]

Thanks for the contribution. A few comments to address, and please add a CHANGELOG.md entry - thanks!

[martinstark]

@dweinber changelog is included in #171 , if that is okay. It could be merged into this branch before merging to develop. The last 3 PRs were all part of the same body of work, but it was desired that PRs were created separately.

[dweinber]

Thanks @martinstark, I've started a conversation around existing vs new APIs separately.

Re: Changelog:
I believe what's done in this PR should also be listed by this PR 🙂 (i.e. just the addition of the new APIs should be listed as part of this PR)

[martinstark]

Re: Changelog:
I believe what's done in this PR should also be listed by this PR 🙂 (i.e. just the addition of the new APIs should be listed as part of this PR)

Sure! Since the PRs are built on top of each other I'll have a small rebase/force-push party to get it sorted once we agree to the finalized API. I'll move the changelog to the appropriate PR when that happens.

[dweinber]

Ah ok, missed that. I thought we'd merge this one, and then 171 would be just done against develop as well.

All good then, don't worry about the changelog.

[martinstark]

Since I'll likely need to make changes here I'll be doing the rebasing regardless, so I can make sure the changelog is in the correct place as part of that

[dweinber]

Hey @martinstark,
As discussed offline, please apply my review comments.

[martinstark]

@dweinber new commits added, pr description updated

[dweinber]

Code looks good, thanks for the updates!