Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react native to 0.73.4 #404

Merged
merged 11 commits into from
Mar 5, 2024
Merged

Update react native to 0.73.4 #404

merged 11 commits into from
Mar 5, 2024

Conversation

matamegger
Copy link
Contributor

@matamegger matamegger commented Mar 1, 2024

Description

To unblock player updates we need to upgrade the react native version. The react native version update also comes with required upgrades of the tooling e.g. jdk, node updates.

Changes

  • Update GH workflows to set up the according jdk, node and xcode version
  • Update to react native 0.73.4 as well as to 0.73.4-0 of the tvos fork
  • Remove flipper integration (not needed by us, and there has been a change in the framework setup)
  • Refactored java app entry points to kotlin (applied from the official template)
  • Updated the gradle setup as well as the build, compile, target and ndk version
  • Removed boost "jfrog" workaround
  • example: Updated react native navigation, orientation locker, safe are context, native screens, system navigation bar
  • example: fixed (now facing) type issues
  • Adjusted the ios project setup in alignment with the changes in react native upgrade helper tool

Checklist

  • 🗒 CHANGELOG entry

@matamegger matamegger force-pushed the upgrade_react_native branch 3 times, most recently from 8d4799f to bb3a815 Compare March 1, 2024 10:25
@matamegger matamegger changed the title Update react native to 0.73.5 Update react native to 0.73.4 Mar 1, 2024
@matamegger matamegger marked this pull request as ready for review March 1, 2024 12:31
@matamegger matamegger requested review from a team as code owners March 1, 2024 12:31
@matamegger
Copy link
Contributor Author

@zigavehovec @rolandkakonyi feel free to redistribute the review. I thought you would be the best match for this kind of PR :)

@stonko1994 stonko1994 removed the request for review from a team March 4, 2024 10:08
# Conflicts:
#	example/ios/Podfile.lock
#	integration_test/ios/Podfile.lock
Copy link
Contributor

@krocard krocard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@rolandkakonyi
Copy link
Contributor

rolandkakonyi commented Mar 4, 2024

I will keep updating this comment as this will take some time 😅

Integration tests: done, passed ✅

Manual testing: done, 1 out of 2 issues fixed ⚠️

  1. Programmatic track selection on iOS: layout is broken, options on the bottom are squished -> Found that the styling is not working anymore and the track list gets squashed to 0 height. I have local changes to fix the layout. ✅ Fixed in 4800a6b
  2. Landscape Fullscreen Handling on Android and iOS has the wrong initial state. It goes full screen but portrait mode. On iOS then it gets stuck as landscape, even staying like that for the list screen.

Code review: done ✅ (minor question only)

Copy link
Contributor

@zigavehovec zigavehovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good 👍
Manual testing for Android looks good apart from the offline feature, where RuntimeException is thrown when trying to start the download:

Caused by: java.lang.SecurityException: Starting FGS with type dataSync callerApp=ProcessRecord{f884966 14500:com.bitmovin.player.reactnative.example/u0a326} targetSDK=34 requires permissions: all of the permissions allOf=true [android.permission.FOREGROUND_SERVICE_DATA_SYNC]

This is unrelated to the changes in this PR but should be very easy to fix (just adding the FOREGROUND_SERVICE_DATA_SYNC permission in the example manifest). Could you take care of this?

@rolandkakonyi rolandkakonyi self-requested a review March 5, 2024 10:48
@matamegger
Copy link
Contributor Author

  1. Landscape Fullscreen Handling on Android and iOS has the wrong initial state. It goes full screen but portrait mode. On iOS then it gets stuck as landscape, even staying like that for the list screen.

This seems to be the case before this PR already. Not going to fix this within this PR.

@matamegger matamegger merged commit 56e5dc1 into development Mar 5, 2024
9 checks passed
@matamegger matamegger deleted the upgrade_react_native branch March 5, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants