-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react native to 0.73.4 #404
Conversation
# Conflicts: # example/ios/Podfile.lock # integration_test/ios/Podfile.lock
8d4799f
to
bb3a815
Compare
aff74b2
to
648d52f
Compare
@zigavehovec @rolandkakonyi feel free to redistribute the review. I thought you would be the best match for this kind of PR :) |
# Conflicts: # example/ios/Podfile.lock # integration_test/ios/Podfile.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍
I will keep updating this comment as this will take some time 😅 Integration tests: done, passed ✅Manual testing: done, 1 out of 2 issues fixed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good 👍
Manual testing for Android looks good apart from the offline feature, where RuntimeException is thrown when trying to start the download:
Caused by: java.lang.SecurityException: Starting FGS with type dataSync callerApp=ProcessRecord{f884966 14500:com.bitmovin.player.reactnative.example/u0a326} targetSDK=34 requires permissions: all of the permissions allOf=true [android.permission.FOREGROUND_SERVICE_DATA_SYNC]
This is unrelated to the changes in this PR but should be very easy to fix (just adding the FOREGROUND_SERVICE_DATA_SYNC permission in the example manifest). Could you take care of this?
This seems to be the case before this PR already. Not going to fix this within this PR. |
Description
To unblock player updates we need to upgrade the react native version. The react native version update also comes with required upgrades of the tooling e.g. jdk, node updates.
Changes
0.73.4
as well as to0.73.4-0
of the tvos forkChecklist
CHANGELOG
entry