Add advertising related player tests #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
force-pushed
the
improve-player-testing-setup
branch
from
b97d304
to
2e6fc90
Compare
rolandkakonyi
commented
Dec 11, 2023
Comment on lines
+60
to
+62
| if (type !== 'progressive') { | ||
| await expectEvent(EventType.AdManifestLoaded, 20); | ||
| } |
There was a problem hiding this comment.
I experienced longer waiting times with the Android emulator, therefore added this extra expectation to stabilize the test. APPLIES TO THE OTHER OCCURRENCES TOO
zigavehovec
approved these changes
Dec 13, 2023
| EventType.AdFinished, | ||
| EventType.AdBreakFinished | ||
| ), | ||
| 18 |
There was a problem hiding this comment.
Is there a reason for this quite specific 18? Just a though, what if we increase the default timeout to account for Android emulators being a bit slower and set it to 20?
There was a problem hiding this comment.
I would not touch the default timeout as usually 10 seconds is pretty long already.
This is specific for ads on the Android emulator so belongs to the specific test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes add player integration tests to verify advertising-related events are emitted.
Changes
Added advertising-related player integration tests.
Checklist
CHANGELOGentry - internal changes only, no changelog needed