Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitmovin Analytics: Bugfix and added two missing attributes #3

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aachenmax
Copy link

I added two missing enums for AnalyticsAttribute: REBUFFER_PERCENTAGE and VIDEOSTART_FAILED.

I fixed a bug/problem for the /analytics/impression API endpoint. The response for this endpoint comes as a python list, which is attempted to be converted into a dictionary, throwing an Exception. Maybe there is a more elegant solution though. Here is some minimal code to reproduce this error without the fix:

from bitmovin_api_sdk import bitmovin_api, AnalyticsLicenseKey

api_key = 'XXX'
tenant_org_id = 'XXX'
license_key = 'XXX'
test_impression = '8b789d1c-a47b-4401-85ef-18ab68113825'
bitmovinApi = bitmovin_api.BitmovinApi(api_key=api_key, tenant_org_id=tenant_org_id)
response = bitmovinApi.analytics.impressions.create(impression_id=test_impression, analytics_license_key=AnalyticsLicenseKey(license_key=licenses_key))
print(response)

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aachenmax
❌ hofmannben
You have signed the CLA already but the status is still pending? Let us recheck it.

Base automatically changed from master to main February 2, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants