v. 0.14.4.5. Fix issue: Transaction.updatedAt is not set at new block #…

…11

core/pom.xml

@@ -22,7 +22,7 @@
     <parent>
         <groupId>org.bitcoinj</groupId>
         <artifactId>bitcoinj-parent</artifactId>
-        <version>0.14.4.4</version>
+        <version>0.14.4.5</version>
     </parent>
 
     <artifactId>bitcoinj-core</artifactId>

core/src/main/java/org/bitcoinj/core/Transaction.java

@@ -55,7 +55,7 @@
  * Whether to trust a transaction is something that needs to be decided on a case by case basis - a rule that makes
  * sense for selling MP3s might not make sense for selling cars, or accepting payments from a family member. If you
  * are building a wallet, how to present confidence to your users is something to consider carefully.</p>
- * 
+ *
  * <p>Instances of this class are not safe for use by multiple threads.</p>
  */
 public class Transaction extends ChildMessage {
@@ -323,7 +323,14 @@ public boolean isPending() {
      */
     public void setBlockAppearance(StoredBlock block, boolean bestChain, int relativityOffset) {
         long blockTime = block.getHeader().getTimeSeconds() * 1000;
-        if (bestChain && (updatedAt == null || updatedAt.getTime() == 0 || updatedAt.getTime() > blockTime)) {
+
+        /* if (bestChain && (updatedAt == null || updatedAt.getTime() == 0 || updatedAt.getTime() > blockTime)) {
+            updatedAt = new Date(blockTime);
+        }*/
+        // We removed for the checks to not overwrite updatedAt in cases for re-orgs.
+        // updatedAt is set by wallet.commit and thus the new block would never set the value.
+        // If there is a re-org the best block is called last as stated in the doc above so the values will be correct.
+        if (bestChain) {
             updatedAt = new Date(blockTime);
         }
 

examples/pom.xml

@@ -21,7 +21,7 @@
     <parent>
         <groupId>org.bitcoinj</groupId>
         <artifactId>bitcoinj-parent</artifactId>
-        <version>0.14.4.4</version>
+        <version>0.14.4.5</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

pom.xml

@@ -4,7 +4,7 @@
 
   <groupId>org.bitcoinj</groupId>
   <artifactId>bitcoinj-parent</artifactId>
-    <version>0.14.4.4</version>
+    <version>0.14.4.5</version>
   <packaging>pom</packaging>
 
   <modules>

tools/pom.xml

@@ -21,7 +21,7 @@
   <parent>
     <groupId>org.bitcoinj</groupId>
     <artifactId>bitcoinj-parent</artifactId>
-      <version>0.14.4.4</version>
+      <version>0.14.4.5</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 

wallettemplate/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <groupId>org.bitcoinj</groupId>
         <artifactId>bitcoinj-parent</artifactId>
-        <version>0.14.4.4</version>
+        <version>0.14.4.5</version>
     </parent>
 
     <artifactId>wallettemplate</artifactId>