Add title inside notifications settings menu

bisq-network · Sep 14, 2024 · 68a4e79 · 68a4e79
1 parent cb2f514
commit 68a4e79
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/apps/desktop/desktop/src/main/java/bisq/desktop/main/content/chat/BaseChatView.java b/apps/desktop/desktop/src/main/java/bisq/desktop/main/content/chat/BaseChatView.java
@@ -22,6 +22,7 @@
 import bisq.desktop.common.view.NavigationView;
 import bisq.desktop.components.controls.DropdownBisqMenuItem;
 import bisq.desktop.components.controls.DropdownMenu;
+import bisq.desktop.components.controls.DropdownTitleMenuItem;
 import bisq.desktop.components.controls.SearchBox;
 import bisq.i18n.Res;
 import javafx.css.PseudoClass;
@@ -182,6 +183,7 @@ private void setUpEllipsisMenu() {
     }
 
     private void setupNotificationsSettingMenu() {
+        DropdownTitleMenuItem title = new DropdownTitleMenuItem(Res.get("chat.notificationsSettingsMenu.title"));
         globalDefault = new NotificationSettingMenuItem("check-white", "check-white",
                 Res.get("chat.notificationsSettingsMenu.globalDefault"), ChatChannelNotificationType.GLOBAL_DEFAULT);
         all = new NotificationSettingMenuItem("check-white", "check-white",
@@ -190,7 +192,8 @@ private void setupNotificationsSettingMenu() {
                 Res.get("chat.notificationsSettingsMenu.mention"), ChatChannelNotificationType.MENTION);
         off = new NotificationSettingMenuItem("check-white", "check-white",
                 Res.get("chat.notificationsSettingsMenu.off"), ChatChannelNotificationType.OFF);
-        notificationsSettingsMenu.addMenuItems(globalDefault, all, mention, off);
+        notificationsSettingsMenu.getStyleClass().add("notifications-settings-menu");
+        notificationsSettingsMenu.addMenuItems(title, globalDefault, all, mention, off);
         notificationsSettingsMenu.setTooltip(Res.get("chat.notificationsSettingsMenu.tooltip"));
     }
 

diff --git a/apps/desktop/desktop/src/main/resources/css/chat.css b/apps/desktop/desktop/src/main/resources/css/chat.css
@@ -329,6 +329,10 @@
     -fx-background-color: -bisq-dark-grey-20;
 }
 
+.notifications-settings-menu .dropdown-menu-popup {
+    -fx-padding: 18 8 8 8 !important;
+}
+
 
 /*******************************************************************************
  * Header                                                                      *

diff --git a/i18n/src/main/resources/chat.properties b/i18n/src/main/resources/chat.properties
@@ -133,6 +133,7 @@ chat.ellipsisMenu.chatRules=Chat rules
 chat.ellipsisMenu.channelInfo=Channel info
 chat.ellipsisMenu.tradeGuide=Trade guide
 
+chat.notificationsSettingsMenu.title=Notification options:
 chat.notificationsSettingsMenu.tooltip=Notification options
 chat.notificationsSettingsMenu.globalDefault=Use default
 chat.notificationsSettingsMenu.all=All messages