Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text-animation #220

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Text-animation #220

merged 1 commit into from
Oct 26, 2020

Conversation

iamneelpatel
Copy link
Contributor

A text animation

The javascript script animates text transition.

Fixed #172

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added screenshots(if any) that prove my fix is effective or that my feature works

Copy link
Owner

@bislara bislara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. It looks good. Well done

@bislara bislara merged commit 43836b4 into bislara:master Oct 26, 2020
@github-actions
Copy link

Thanks very much for contributing! Your pull request has been merged 🎉 Hoping for more contribution from you in future.
Do give a ⭐ if you like this project

Happy hacking and Learning ✌🤟
Thanks again! ✨

@bislara
Copy link
Owner

bislara commented Oct 26, 2020

@m4dummies hey u didn't remove the 3d animation file outside its folder. It's still there. If you have any other animation then create PR with that changing this. or else u can create a PR now fixing this

@iamneelpatel
Copy link
Contributor Author

Oh, i missed it. Thanks for letting me know ill fix it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS Animations
2 participants