Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): add soul components in Homepage #1386

Open
wants to merge 24 commits into
base: vibes/soul
Choose a base branch
from

Conversation

jorgemoya
Copy link
Contributor

@jorgemoya jorgemoya commented Sep 18, 2024

What/Why?

  • Setups tailwind config and fonts.
    • Added some temporary colors and plugins to prevent eslint issues.
  • Modifies homepage to use Soul vibe.
    • Adds necessary vibe components in /components/vibes/ for now (no overwrites or deletes).
  • Cart count is not working.
  • Enabled two locales for testing purposes.

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner September 18, 2024 21:29
Copy link

changeset-bot bot commented Sep 18, 2024

⚠️ No Changeset found

Latest commit: 8a66729

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview Sep 18, 2024 10:14pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Sep 18, 2024 10:14pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 10:14pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 10:14pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 10:14pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 10:14pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 10:14pm

@jorgemoya jorgemoya changed the title feat(core): refactor(core): add soul components in Homepage Sep 18, 2024
Comment on lines +7 to +14
// eslint-disable-next-line @typescript-eslint/require-await
export const search = async (formData: FormData) => {
const searchTerm = z.string().parse(formData.get('searchTerm'));

if (searchTerm) {
redirect(`/search?term=${searchTerm}`);
}
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like server actions need to be async functions, but there's no async function inside this. Is this the best way to solve this?

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-mlr8w59sm-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 66
🟠 Accessibility 80
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 89
🟠 Accessibility 81
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant