Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legacy): Support local BIDS-URIs for IntendedFor fields #2069

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Aug 7, 2024

Was going to skip validation for the legacy validator for bids-standard/bids-examples#455, but this was pretty straightforward just to fix.

It's not 100% BIDS-URI support, but it is easily over 80% for these fields.

@effigies effigies force-pushed the legacy/bids-uri-intendedfor branch from 70077f6 to a6a19f8 Compare August 7, 2024 13:51
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (1453bc1) to head (a6a19f8).
Report is 2 commits behind head on master.

Files Patch % Lines
...lidator/validators/microscopy/checkJSONAndField.js 83.33% 1 Missing ⚠️
bids-validator/validators/nifti/nii.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2069      +/-   ##
==========================================
+ Coverage   85.75%   87.09%   +1.33%     
==========================================
  Files          91      139      +48     
  Lines        3785     6673    +2888     
  Branches     1218     1574     +356     
==========================================
+ Hits         3246     5812    +2566     
- Misses        453      771     +318     
- Partials       86       90       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies added the legacy label Aug 7, 2024
@rwblair rwblair merged commit 12f40bb into bids-standard:master Aug 7, 2024
15 of 16 checks passed
@effigies effigies deleted the legacy/bids-uri-intendedfor branch August 7, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants