Remove SKIP_VALIDATION from datasets the deno validator can handle #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of bids-standard/bids-validator#1987, these should no longer raise errors.
effigies
force-pushed
the
validate-more-examples
branch
from
a1a7df7
to
cb36dfd
Compare
|
Wow -- it is green, great! Would it still be feasible to request some kind of an option/switch to cause them to become ERRORs so we could detect/fix them up, such as in then examples? (I don't know if it would be feasible to aim to fix all the WARNINGs since didn't check how many we do have ATM) |
yarikoptic
approved these changes
Jun 7, 2024
|
Yes, I think we need a CLI or config option to override the severity level of issues. If that's not already an issue on the validator, we should add it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of bids-standard/bids-validator#1987, these should no longer raise errors.