-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enh][PET] add example for ReconFilterType is 'none' #427
Open
bendhouseart
wants to merge
6
commits into
master
Choose a base branch
from
add-recon-filter-type-none-example
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1ddcd31
add example for ReconFilterType is 'none'
bendhouseart ac4061e
Apply suggestions from code review
bendhouseart 6833cbe
Update sub-01_pet.json
bendhouseart 2d41f1f
Apply suggestions from code review
bendhouseart 7a5b36b
Update pet006/README
bendhouseart 676a60f
Update pet006/sub-01/pet/sub-01_pet.json
bendhouseart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| This dataset consists of a single calibration scan done on a Phantom, it's primary use is to ensure the behavior defined by the BIDS Speficication with respect to | ||
| If ReconMethodParameters = ['none']; then ReconFilterSize is optional and ReconMethodParameterLabels = ['none'] are valid. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| {"BIDSVersion":"1.9.0", | ||
| "License":"CCO license", | ||
| "Name":"BIDS Example Dataset PET 006", | ||
| "Authors":["Murat Bilgel", "Cyril Pernet", "Anthony Galassi"], | ||
| "Acknowledgements":"John Hopkins University PET team for scanning this phantom.", | ||
| "Funding":["Not Sure"], | ||
| "DatasetDOI":""} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "participant_id":{ | ||
| "LongName":"Participant Id", | ||
| "Description":"label identifying a particular subject" | ||
| }, | ||
| "weight":{ | ||
| "LongName":"Weight" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| participant_id weight | ||
| sub-01 4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| "AcquisitionMode": "list mode", | ||
| "AttenuationCorrection": "measured(emission present), 0.096000 cm-1, attenuation smooth", | ||
| "AttenuationCorrectionMethod": "measured(emission present), 0.096000 cm-1, attenuation smooth", | ||
| "BodyPart": "Phantom", | ||
| "DecayCorrectionFactor": [1.42614], | ||
| "DoseCalibrationFactor": 1323, | ||
| "FrameDuration": [98000], | ||
| "FrameTimesStart": [0], | ||
| "ImageDecayCorrected": true, | ||
| "ImageDecayCorrectionTime": 0, | ||
| "InjectedMass": 181149988.3691438, | ||
| "InjectedMassUnits": "ug", | ||
| "InjectedRadioactivity": 75.84999999999999, | ||
| "InjectedRadioactivityUnits": "MBq", | ||
| "InjectedVolume": 0, | ||
| "InjectionStart": 0, | ||
| "InstitutionName": "NIH Clinical Center, USA", | ||
| "Manufacturer": "GE MEDICAL SYSTEMS", | ||
| "ManufacturersModelName": "GE Advance", | ||
| "ModeOfAdministration": "infusion", | ||
| "ReconFilterType": "none", | ||
| "ReconMethodName": "3D Kinahan - Rogers", | ||
| "ReconMethodParameterLabels": [ | ||
| "none" | ||
| ], | ||
| "ScanStart": 0, | ||
| "ScatterCorrectionMethod": "Gaussian Fit", | ||
| "SpecificRadioactivity": 418713.8, | ||
| "SpecificRadioactivityUnits": "Bq/g", | ||
| "TimeZero": "12:44:31", | ||
| "TracerName": "FDG", | ||
| "TracerRadionuclide": "F18", | ||
| "Units": "Bq/mL", | ||
| "filename": "D:\\BIDS\\ONP\\OpenNeuroPET-Phantoms\\sub-GeneralElectricAdvanceJHU\\pet\\sub-GeneralElectricAdvanceJHU_pet.json" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, reading the spec, it says
but that seems odd. If it's
["abc", "def", "none"], presumably you want units and values. I suppose the text should actually say 'is not["none"]'? I can probably do that in schema. Matching any might require me to bug Ross.What is currently implemented is:
We could update the text to allow that, but I think probably
["none"]is the cleaner solution, so that the type is constant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mnoergaard Would you mind commenting on the original intent here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original intent goes back to the PET guidelines paper (https://journals.sagepub.com/doi/10.1177/0271678X20905433) where the ReconMethodParameterLabels was decided to be mandatory. In most cases, there are multiple reconstruction parameters and labels, however, for some older scanners there no recon parameters. As far as I remember, for the old validator, it was not easy to combine datatypes depending on the need, so it was decided to keep this as an array of strings. However, it is not so clean in the case of no parameters (even with ["none"]. Just "none" would be the cleanest.