Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Face13 updates #379

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

Andesha
Copy link
Contributor

@Andesha Andesha commented Jun 14, 2023

This PR is currently a draft, however, the Face13 dataset has been updated to include HED tags!

There will be more commits to updating events files but this is the start.

Other minor fixes include updates to the coordsystem files, etc

cc @christinerogers

@effigies effigies marked this pull request as draft June 14, 2023 14:50
@effigies
Copy link
Contributor

Marked as draft so it's obvious to reviewers. There's a "Ready for review" button you can press whenever you want to turn it green again.

@christinerogers
Copy link

this is contributed for EEGNet discussions around HED tags, how derivatives are evolving, etc.

@@ -12,6 +12,9 @@
"ReferencesAndLinks": [
"http://jov.arvojournals.org/article.aspx?articleid=2121634"
],
"HEDVersion" : "8.1.0",
"DatasetDOI": "10.1167/13.5.22",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Dataset DOI need to be updated with this PR? @Andesha

@@ -1,5 +1,5 @@
{
"Name": "faceFO",
"Name": "Face13-FAC",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hyphens and underscores are reserved in BIDS so we should avoid using here I think.

@VisLab
Copy link
Member

VisLab commented Jun 23, 2023

The events.tsv files still have HED columns that duplicate what is in the JSON file at the top level. It should be one or the other.

Also, I thought this dataset might have SCORE annotations, but I didn't see any in the example. Could you point me in the right direction on this? The tags I saw were all from the standard library, in which case the HEDVersion should just be "8.1.0" or better "8.2.0" since that is the latest.

@VisLab
Copy link
Member

VisLab commented Jun 23, 2023

The validation seems to be failing because of large files. You will want to cutoff the number of events in the events.tsv file. If you remove the HED columns in the events.tsv and just keep the top-level JSON sidecar, you may be able to squeak by with full files.

@Andesha
Copy link
Contributor Author

Andesha commented Sep 26, 2023

@VisLab just a note: it appears as though the BIDS validator is struggling to retrieve partnered schemas...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants