Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: API build with buf #85

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Fix: API build with buf #85

merged 3 commits into from
Jun 26, 2023

Conversation

D4ryl00
Copy link
Collaborator

@D4ryl00 D4ryl00 commented Jun 26, 2023

The project use go-1.19 so we need to update the Dockerfile to use too go-1.19 to build the API.
That fixes a dependency issue when compiling the API.

I added ASDF in the Dockerfile to get the right version of it for compiling the API.

@D4ryl00 D4ryl00 requested a review from gfanton June 26, 2023 10:05
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@D4ryl00 D4ryl00 merged commit dc135f4 into berty:main Jun 26, 2023
12 of 13 checks passed
@D4ryl00 D4ryl00 deleted the fix/api-build branch June 26, 2023 14:43
@github-actions
Copy link

🎉 This PR is included in version 1.11.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants