Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update kubo to 0.27.0 #110

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

D4ryl00
Copy link
Contributor

@D4ryl00 D4ryl00 commented Mar 29, 2024

This PR updates Kubo to v0.27.0 and its dependencies.
Because github.com/ipfs/interface-go-ipfs-core is now deprecated and its interfaces have been moved to github.com/ipfs/boxo and github.com/ipfs/kubo, we updated the import path accordingly.

We also updated the go.mod with the go version 1.21.8 (latest - 1 Go version).

@D4ryl00 D4ryl00 requested a review from jefft0 March 29, 2024 16:25
@D4ryl00 D4ryl00 self-assigned this Mar 29, 2024
@D4ryl00 D4ryl00 marked this pull request as draft March 29, 2024 16:26
@D4ryl00 D4ryl00 removed the request for review from jefft0 March 29, 2024 16:26
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.44%. Comparing base (f638d42) to head (27f4e0a).

Files Patch % Lines
log.go 0.00% 1 Missing and 1 partial ⚠️
io/cbor/cbor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   68.87%   68.44%   -0.44%     
==========================================
  Files          23       23              
  Lines        1825     1822       -3     
==========================================
- Hits         1257     1247      -10     
  Misses        365      365              
- Partials      203      210       +7     
Flag Coverage Δ
unittests 68.44% <25.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@D4ryl00 D4ryl00 marked this pull request as ready for review March 29, 2024 23:35
@D4ryl00 D4ryl00 requested a review from jefft0 March 29, 2024 23:35
@jefft0
Copy link
Collaborator

jefft0 commented Apr 2, 2024

I think the new version of kubo doesn't print those annoying warnings, so we can remove these two lines from the expected test output:
https://github.com/D4ryl00/go-ipfs-log/blob/a642af694adca34bf48d5a7e71460fbd851173c7/example/example_log_append_test.go#L157-L158

GitHub
Go version of append-only log CRDT on IPFS. Contribute to D4ryl00/go-ipfs-log development by creating an account on GitHub.

Copy link
Collaborator

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with make test and make lint. (See my comment about removing kubo warnings.)

@jefft0 jefft0 mentioned this pull request Apr 3, 2024
@jefft0
Copy link
Collaborator

jefft0 commented Apr 5, 2024

@D4ryl00 will investigate the error when running the example. Change to Draft.

@jefft0 jefft0 marked this pull request as draft April 5, 2024 12:08
@jefft0 jefft0 marked this pull request as ready for review April 5, 2024 14:03
@D4ryl00 D4ryl00 merged commit be4faf7 into berty:master Apr 5, 2024
8 checks passed
@D4ryl00 D4ryl00 deleted the chore/update-ipfs branch April 5, 2024 14:13
Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 1.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants