Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: scoped discovery #247

Merged
merged 7 commits into from
Sep 16, 2024
Merged

docs: scoped discovery #247

merged 7 commits into from
Sep 16, 2024

Conversation

v-rocheleau
Copy link
Contributor

@v-rocheleau v-rocheleau commented Jun 18, 2024

Discovery configuration hierarchy

Discovery configs can be provided at the following levels:

  • Node:
    • Mounted JSON file
    • None => no public data
  • Project:
    • Optional at project creation
    • None => node discovery fallback
  • Dataset:
    • Optional at dataset creation
    • None => project discovery fallback

When querying a scoped Katsu endpoint, the user can scope the query for a specific project/dataset by using the project and/or dataset query parameters. This does not apply to endpoints that expect URL parameters for project/dataset IDs, like datasets/<str:dataset_id>/summary.

Katsu handles scoped queries this way:

  1. {endpoint}?dataset={dataset_uuid}
    • uses the dataset discovery config
  2. {endpoint}?project={project_uuid}&dataset={dataset_uuid}
    • uses the dataset discovery config
    • the dataset MUST belong to the project
  3. {endpoint}?project={project_uuid}
    • uses the project's discovery config
  4. {endpoint} OR {endpoint}?project=""&dataset=""
    • uses the node's discovery config
    • compatibility with older bento_web and bento_public versions

Katsu endpoints scoping

The following endpoints can now be queried with the project and/or dataset query parameters.

  1. datasets/str:dataset_id/summary
  2. public_search_fields
  3. search_overview
  4. public_overview
  5. overview
  6. public
  7. beacon_search

New public endpoint on katsu:

  • public_rules: returns the scoped public rules (max query params and count threshold)
    • related gateway PR

@v-rocheleau v-rocheleau changed the base branch from releases/v16 to releases/v17 September 10, 2024 17:42
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, otherwise looks good

docs/deployment.md Outdated Show resolved Hide resolved
docs/public_discovery.md Outdated Show resolved Hide resolved
docs/public_discovery.md Outdated Show resolved Hide resolved
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidlougheed davidlougheed changed the title feat: scoped discovery docs: scoped discovery Sep 16, 2024
@v-rocheleau v-rocheleau merged commit 4cc33be into releases/v17 Sep 16, 2024
2 checks passed
@v-rocheleau v-rocheleau deleted the feat/discovery branch September 16, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants