Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13] feat!: new notification service with authz #151

Merged
merged 7 commits into from
Jul 18, 2023
Merged

[13] feat!: new notification service with authz #151

merged 7 commits into from
Jul 18, 2023

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed changed the title feat: new notification service with authz [13] feat: new notification service with authz Jul 17, 2023
@davidlougheed davidlougheed changed the title [13] feat: new notification service with authz [13] feat!: new notification service with authz Jul 17, 2023
@davidlougheed davidlougheed marked this pull request as ready for review July 17, 2023 20:19
v-rocheleau
v-rocheleau approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I assume notification is behind the public url because it now includes authz?

@davidlougheed
Copy link
Member Author

yep!

@davidlougheed davidlougheed merged commit fd81df0 into releases/v13 Jul 18, 2023
2 checks passed
@davidlougheed davidlougheed deleted the feat/v13/new-notif branch July 18, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rocheleau v-rocheleau v-rocheleau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @v-rocheleau