Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildozer: handle multiple glob tokens in set command #1250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stagnation
Copy link

To address #1249. This continues the special case handling for globs in set X glob(...) commands from #100. Ideally we should have a higher parsing level to extract the inner arguments from functions so they can be reorganized like regular files are. This does not work for add X glob(...) which follows the status quo. At the moment we only use set internally but can look at add too on the back burner. Thanks for this wonderful tool!

@stagnation stagnation changed the title Feature/buildozer handle multiple glob tokens buildozer: handle multiple glob tokens in set command Mar 11, 2024
In the 'set' command, following the work from bazelbuild#100.
@stagnation stagnation force-pushed the feature/buildozer-handle-multiple-glob-tokens branch from 3c068ff to 2707289 Compare March 11, 2024 13:44
@stagnation
Copy link
Author

Just found this: #572 which also improves globs, higher up in the parser. Is that a better solution to revive and continue with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant