fix(runfiles): support bzlmod repo mappings #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
requested review from
mattem,
gregmagolan and
alexeagle
as code owners
jbedard
force-pushed
the
runfiles-bzlmod
branch
2 times, most recently
from
e9895ad
to
e826550
Compare
jbedard
force-pushed
the
runfiles-bzlmod
branch
from
e826550
to
09d0738
Compare
jbedard
commented
Sep 6, 2024
jbedard
force-pushed
the
runfiles-bzlmod
branch
3 times, most recently
from
cf0fa5b
to
e2da746
Compare
jbedard
commented
Sep 12, 2024
jbedard
force-pushed
the
runfiles-bzlmod
branch
3 times, most recently
from
60b3e57
to
db7fa65
Compare
gregmagolan
reviewed
Sep 16, 2024
gregmagolan
reviewed
Sep 16, 2024
jbedard
force-pushed
the
runfiles-bzlmod
branch
from
db7fa65
to
61843b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by: bazelbuild/rules_python@9662139, bazelbuild/rules_go@fd8c041
It seems like the
packages/runfiles/testshave not been run for quite some time and can't be run in their current form. I've added those tests rules_js in aspect-build/rules_js#1895 and I've been testing there where tests were failing with bzlmod which this PR fixes.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3714
What is the new behavior?
Does this PR introduce a breaking change?
Other information