Shorten git version to generate correct container DNS hostname #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also be interested in this @xiaohui-zhangxh. I posted a PR recently. Different solution to yours #409. I think I would be happy with either but I agree I think shortening the container name would be good. |
|
@hey-leon didn't notice you have created one. Closing due to duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I got a problem on resolving app IP address by container name, like this 'myapp-web-staging-599126a8f6c31f286636a8675226d4ab6585287c_uncommitted_94602f20085489c4' has 87 chars, according to https://en.wikipedia.org/wiki/Subdomain#Overview , "Each label may contain from 0 to 63 [octets]", this is invalid subdomain, so I can't container IP with:
We can get short git version instead of long one, and make a version as short as possible.