Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply ShellCheck suggestions #106

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

apply ShellCheck suggestions #106

wants to merge 7 commits into from

Conversation

Flupp
Copy link

@Flupp Flupp commented Mar 7, 2021

I fixed some issues reported by ShellCheck. Some of them can be considered stylistic, however, some of them indicate actual problems.

@Flupp
fix SC2004: $/${} is unnecessary on arithmetic variables.
79531a7 
This is a suggestion from ShellCheck.
@Flupp
fix SC2046: Quote this to prevent word splitting.
4bd0b47 
This is a suggestion from ShellCheck.
@Flupp
fix SC2059: Don't use variables in the printf format string.
5d46334 
This is a suggestion from ShellCheck.
@Flupp
fix SC2071: > is for string comparisons. Use -gt instead.
418ef6c 
This is a suggestion from ShellCheck.
@Flupp
fix SC2086: Double quote to prevent globbing and word splitting.
76480c1 
This is a suggestion from ShellCheck.
@Flupp
fix SC2140: Word is of the form "A"B"C".
915634a 
This is a suggestion from ShellCheck.
@Flupp
fix SC2181: Check exit code directly
cb1041c 
… with e.g. 'if mycmd;', not indirectly with $?.

This is a suggestion from ShellCheck.
@baodrate baodrate mentioned this pull request Feb 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Flupp