Strict tiling #194
Strict tiling #194
Conversation
There was a problem hiding this comment.
Is there a reason why this PR includes unrelated README changes?
There was a problem hiding this comment.
i forgot to switch branches
There was a problem hiding this comment.
Please just cherrypick your commit to the right branch or something, if I really have to go through 249 files by hand I'd refer you'd only keep it to the relevant ones
There was a problem hiding this comment.
I'm not sure you meant to commit this
There was a problem hiding this comment.
no i did not! good catch thanks
There was a problem hiding this comment.
(I'll mark this conversation as resolved when you fix this)
There was a problem hiding this comment.
This file seems to be using the old header comment. Are there any others like it?
There was a problem hiding this comment.
come to think of it this should probably be reimported because i imported it using an older version of the game, but i'd need a copy of the latest version of baba is you for that which i don't. have at the moment, because i'm at college
There was a problem hiding this comment.
I do. If you'd like, and if you can give me proper instructions, I can do it for you.
There was a problem hiding this comment.
Why did so many unrelated sprites and such change? Is this metadata? Should we be using optipng?
There was a problem hiding this comment.
i uh accidentally committed an old version of the basegame palettes so i fixed that here. should've done it on main but i forgot to switch branches
| .replace("|", "vert") | ||
| .replace("?", "quest") | ||
| .replace("*", "ast") | ||
| ) |
There was a problem hiding this comment.
This seems like it could become a problem (also, no handling of '?)
There was a problem hiding this comment.
what do you think i should do?
There was a problem hiding this comment.
I'm not sure, it's just that this doesn't catch all special characters and endlessly replace chaining seems like a bad idea
I'd prefer something that just applies to certain character ranges but I'm not sure where the character names would come from
| if tiling == TilingMode.TILING: | ||
| # Check for diagonal tiling | ||
| if pathlib.Path(f"data/sprites/{constants.BABA_WORLD}/{sprite}_16_1.png").exists(): | ||
| tiling = +TilingMode.DIAGONAL_TILING |
There was a problem hiding this comment.
Copy pasted check from earlier?
There was a problem hiding this comment.
Is there anything that reasonably can or should be done about this?
| # | ||
| # ---------------------------------------------------------------------------- | ||
| """) | ||
| f.write("# Please read CONTRIBUTING.md for guidance on how to properly edit this file.\n\n\n") |
There was a problem hiding this comment.
Also seems copy pasted?
There was a problem hiding this comment.
This might need to be a constant or something.
|
Most of this boils down to "please clean up this branch and its diff" |
|
@balt-dev your turn. |
|
give me a little while, i'm in class |
|
thanks for doing this btw |
Tiling mode is now an enumerated string, out-of-bounds animation frames now give an error, and many tiles have been fixed.