Fix secret generation for mutual ssl config

ballerina-platform · Feb 21, 2024 · 0cce9a7 · 0cce9a7
1 parent eb0c465
commit 0cce9a7
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/compiler-plugin/src/main/java/io/ballerina/c2c/tasks/C2CAnalysisTask.java b/compiler-plugin/src/main/java/io/ballerina/c2c/tasks/C2CAnalysisTask.java
@@ -124,6 +124,9 @@ private void addClientList(List<ClientInfo> clientInfoList) throws KubernetesPlu
             final Optional<MutualSSLConfig> mutualSSLConfig = clientInfo.getHttpsConfig().getMutualSSLConfig();
             if (mutualSSLConfig.isPresent()) {
                 String sslCertPath = mutualSSLConfig.get().getPath();
+                if (KubernetesUtils.isBlank(sslCertPath)) {
+                    continue;
+                }
                 String sslCertPathContent = readSecretFile(sslCertPath);
                 SecretModel secretModel;
                 Optional<SecretModel> existing = getSecretByMountPathExists(getMountPath(sslCertPath));
@@ -216,7 +219,7 @@ private Set<SecretModel> processSecureSocketConfig(ListenerInfo listenerInfo) th
         if (secureSocketConfig.isPresent()) {
             String path = secureSocketConfig.get().getPath();
             final String validName = getValidName(listenerInfo.getName());
-            if (path != null && !"".equals(path)) {
+            if (!KubernetesUtils.isBlank(path)) {
                 String keyStoreContent = readSecretFile(path);
                 secretModel.setName(validName + "-secure-socket");
                 secretModel.setMountPath(getMountPath(path));
@@ -258,6 +261,9 @@ private Set<SecretModel> processSecureSocketConfig(ListenerInfo listenerInfo) th
         }
         if (mutualSSLConfig.isPresent()) {
             String sslCertPath = mutualSSLConfig.get().getPath();
+            if (KubernetesUtils.isBlank(sslCertPath)) {
+                return secrets;
+            }
             String sslCertPathContent = readSecretFile(sslCertPath);
             if (getMountPath(sslCertPath).equals(secretModel.getMountPath())) {
                 // Same mount path as key config add data to existing secret.