feat: add permit2 subSteps #1141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: migrate to dRPC * chore: disable foundry cache in GHA
* chore: Init * feat: add prop slippage count down animation * refactor: remove logs and comments * feat: remove animation * chore: Adjust balances * chore: Adjust balances in provider * chore: Cleanup * chore: Revert numbers change --------- Co-authored-by: Anastasios <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
agualis
commented
Oct 2, 2024
| @@ -23,9 +23,9 @@ export function Steps({ transactionSteps }: Props) { | |||
| colorMode={colorMode} | |||
| isLastStep={isLastStep(index)} | |||
| /> | |||
| {!isLastStep(index) && ( | |||
| {/* {!isLastStep(index) && ( | |||
There was a problem hiding this comment.
@uiuxxx I commented out this vertical separator that only worked when no subSteps are present. We need something that looks good in both scenarios
agualis
commented
Oct 2, 2024
| function SubSteps({ color, subSteps }: { color: string; subSteps: SubSteps }) { | ||
| return ( | ||
| <Box mt="1" pl="2" p="1"> | ||
| {subSteps.gas === 0 && ( |
There was a problem hiding this comment.
@uiuxxx For now I only show Signature: Free for permit substeps. I want to finish implementing the pool actions and then we can talk about the gas implementation depending of the available time left.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of weighted pool for testing
permit2 add liquidity:https://test-v3-git-feat-substeps-balancer.vercel.app/pools/sepolia/v3/0x3e8b62395aea51c3d7bdfeb8cde7d4a272c34750/add-liquidity