Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sparkles star system to differentiate between different yield types #1110

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

uiuxxx
Copy link
Contributor

@uiuxxx uiuxxx commented Sep 19, 2024

  1. Added new light and dark mode sparkles colors
  2. Added new 'Single star' to display pool's with swap fees only
  3. Single star icon
    • Assigned new single star icon StarIcon.tsx to display only when a pool has no other yield beyond swap fees.
    • Use the gray colors already defined in the defaultGrad
  4. Gray sparkles icon
    • This icon with the usual 3 stars should be assigned to any pool with yield in addition to swap fees, but with no staking yield.
  5. Orange sparkles
    • This will now only be used to denote pools with staking incentives (could be BAL or other staking incentives)
  6. Gold sparkles icon
    • Bring back the gold sparkles icon for the BAL / WETH 80/20 pool (it got lost with the recent API update)

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 9:41am
test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 9:41am

@garethfuller garethfuller merged commit 7240f34 into main Sep 20, 2024
7 checks passed
@garethfuller garethfuller deleted the ui/sparkles branch September 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants