WIP: Adjust stable math & live balances rounding #1020
Draft
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
computeInvariant
returns the same for round up and down in Stable pool. The invariant is precise, but we should still make a difference to favor the vault when computing unbalanced liquidity operations.Regarding the rounding for live balances: it's more convenient to round up in general (trivial to verify for proportional adds by inspecting the code), but in particular, nonlinear math involved computing the invariants might have significant impact under very specific conditions and pool types. What matters is to prevent roundtrips, and remove liquidity is computed rounding down. Then, using the same rounding for unbalanced add / remove reduces one variable that can affect how the pool prices the assets.
Type of change
Checklist:
main
, or there's a description of how to mergeIssue Resolution