Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase LBP #1961

Merged
merged 7 commits into from
Nov 2, 2022
Merged

Rebase LBP #1961

merged 7 commits into from
Nov 2, 2022

Conversation

EndymionJkb
Copy link
Collaborator

Description

We're likely going to change this in other ways, but rebase it as a start.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

Advances #1953

TomAFrench
TomAFrench reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that there's quite a few things we'll want to change to match the new architecture. I've found a couple of correctness issues but other than those we can merge and migrate stuff over time.

pkg/pool-weighted/contracts/lbp/LiquidityBootstrappingPool.sol Outdated Show resolved Hide resolved
pkg/pool-weighted/contracts/lbp/LiquidityBootstrappingPool.sol Outdated Show resolved Hide resolved
@TomAFrench TomAFrench merged commit 0b5e10d into master Nov 2, 2022
@TomAFrench TomAFrench deleted the rebase-lbp branch November 2, 2022 16:27
TomAFrench added a commit that referenced this pull request Nov 10, 2022
@TomAFrench
Merge branch 'master' into new-deployments
949e1a5 
* master:
  Use complete task names in deployment scripts to avoid collisions. (#1998)
  Add `IL2GaugeCheckpointer` to interfaces changelog. (#1995)
  Add Certora ComposableStablePool report (#1967)
  Adaptor entrypoint (#1977)
  ESLint + prettier update (#1988)
  Update node engine in main package.json. (#1989)
  Update dependencies (#1985)
  Add note about Node / Yarn versions in README. (#1987)
  refactor: use constants rather than literals in poolState decoding (#1980)
  Provide a 'contract' argument to extract-artifacts  (#1951)
  Update hardhat verifier (#1968)
  Rebase LBP (#1961)
  refactor: replace UNHANDLED_BY_LINEAR_POOL with UNIMPLEMENTED (#1976)
  chore: silence hardhat warnings in distributors package (#1975)
  Upgrade hardhat (#1974)
  Add managed pool action ids (#1970)
  Authorizer refactor preparation (tests) (#1965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EndymionJkb @TomAFrench