Rebase LinearPool #1955
Merged
Rebase LinearPool #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/pool-linear/contracts/LinearPool.sol # pkg/pool-utils/contracts/BasePool.sol
# Conflicts: # pkg/pool-linear/contracts/LinearPool.sol
nventuro
reviewed
Oct 28, 2022
nventuro
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the infrastructure in place (NewBasePool in pool-utils, used by ManagedPool), make LinearPool also use NewBasePool.
It required minor changes to internal functions in NewBasePool: initialization required another argument, and we need to override
_getMinimumBpt. I put in a check to not mint 0 tokens (and emit an event with 0); could remove if we don't mind that. (Not an optimization concern, since it's only called once; I mainly thought the event might be confusing.)Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution
Advances #1953