Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove address book config and script. Update config values. #575

Merged
merged 3 commits into from
May 14, 2024

Conversation

johngrantuk
Copy link
Member

In preparation for adding new networks.

Old script to generate network addresses was failing and also generated more info than was needed which made it unclear and hard to check what was needed. Removed script and json. Going forward new networks can be manually added to config.ts

config.ts should have been updated with values from addresses.json but might be worth randomly checking some.

@johngrantuk johngrantuk reopened this May 9, 2024
Copy link
Member

@brunoguerios brunoguerios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually prefer automating these processes, but I agree that having this address generation code as a dependency is not ideal as we don't update addresses or add new chains that often.
Adding manually seems to make more sense 👍
Ps: approved assuming only non-relevant tests are failing. Let me know if that's not the case 😉

@johngrantuk johngrantuk merged commit d2cab84 into develop May 14, 2024
2 of 3 checks passed
@johngrantuk johngrantuk deleted the config-manual branch May 14, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants