Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/agg pools #545

Merged
merged 13 commits into from
Sep 2, 2024
Merged

Feat/agg pools #545

merged 13 commits into from
Sep 2, 2024

Conversation

franzns
Copy link
Collaborator

@franzns franzns commented Jul 4, 2024

No description provided.

Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: c94d6ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
backend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@franzns franzns marked this pull request as ready for review August 27, 2024 15:11
"""
Dynamic data such as token balances, swap fees or volume
"""
dynamicData: GqlPoolDynamicData!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we return only what's needed. Currently there is a lot of "UI" stats data that is not needed and is cluttering the type. Same for token lists and nested pools. Skipping some "included" table queries will make it faster.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just trying to reuse as much as possible as we will refactor the whole thing early next year

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had an issue locally where the query stalled when not specifying any chain, let's add a default limit at least, so the query doesn't hang.

modules/pool/pool.service.ts Show resolved Hide resolved
@franzns franzns linked an issue Aug 28, 2024 that may be closed by this pull request
@franzns franzns merged commit d61718a into v3-canary Sep 2, 2024
1 check passed
@franzns franzns deleted the feat/agg-pools branch September 2, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new pool list (aggregator view)
2 participants