-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/agg pools #545
Feat/agg pools #545
Conversation
🦋 Changeset detectedLatest commit: c94d6ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
""" | ||
Dynamic data such as token balances, swap fees or volume | ||
""" | ||
dynamicData: GqlPoolDynamicData! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we return only what's needed. Currently there is a lot of "UI" stats data that is not needed and is cluttering the type. Same for token lists and nested pools. Skipping some "included" table queries will make it faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just trying to reuse as much as possible as we will refactor the whole thing early next year
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had an issue locally where the query stalled when not specifying any chain, let's add a default limit at least, so the query doesn't hang.
No description provided.