Token yields update #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i suppose ib stands for yield bearing
franzns
requested changes
Jan 11, 2024
modules/network/arbitrum.ts
Outdated
| }, | ||
| plsRDNT: { | ||
| tokenAddress: '0x6dbf2155b0636cb3fd5359fccefb8a2c02b6cb51', | ||
| sourceUrl: 'https://plutusdao.io/api/getPlsRdntInfo', |
There was a problem hiding this comment.
is the cloudflare captcha fixed?
There was a problem hiding this comment.
Shall we remove this until we receive confirmation it's working?
modules/network/fantom.ts
Outdated
Comment on lines
249
to
256
| defaultHandlers: { | ||
| ankrETH: { | ||
| tokenAddress: '0x12d8ce035c5de3ce39b1fdd4c1d5a745eaba3b8c', | ||
| sourceUrl: 'https://api.staking.ankr.com/v1alpha/metrics', | ||
| path: 'services.{serviceName == "eth"}.apy', | ||
| isIbYield: true, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
this is already added via the ankr YB apr service. remove the ankr specific service if it works with the default one. For all chains
There was a problem hiding this comment.
good point, missed that, removed the custom one.
franzns
approved these changes
Jan 12, 2024
franzns
added a commit
that referenced
this pull request
Jan 16, 2024
* fix remaining phantomstable pool type checks * Update on change only (#30) * only update gauges if necessary * only update masterchef farms if necessary * Token yields update (#28) * renaming ib to yb i suppose ib stands for yield bearing * new aprs * removing obsolete ankr apr handler * fix plutusdao APR url * removing sentry integrations (#36) * create separate featuredPools endpoint for v3 (#34) * create separate featuredPools endpoint for v3 * cleanup * require chains param * stop token price purge for now (#41) --------- Co-authored-by: gmbronco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17