V3 canary #133
Merged
V3 canary #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
franzns
commented
Feb 9, 2024
•
franzns
commented
- use b-sdk entities for SOR
- change gnosis prod rpc
- eseth apr source
- no sanity for featured pools
- sveth apr source
- fix pool token dynamic data
- fix SOR route share
- replace dynamic data tables with jsonb column
- add chain param to token price queries
- change sakura rpcs
create dynamic data on update if missing
use b-sdk entities
downgrade b-sdk version
change gnosis prod rpc
* properly account for shares * add effective SP
* removing pool type based tables * reading from pool data column instead of a table * fix getGyroPools chains query param * removing quick fix GyroData table inserts * fix: fx data defaults * migrate type specific dynamic data to json column * pools.type_data column * column naming fix
fix type mapping
* svEth APR * svEth apr units fix * harcoding rpc url for sveth APR
gmbronco
approved these changes
Feb 12, 2024
Comment on lines
+98
to
+99
| } else if (!chains) { | ||
| throw new Error('poolGetGyroPools error: Provide "chains" param'); |
There was a problem hiding this comment.
don't we want to make chain optional? adding type parameter to the pools query might save us some complexity as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.