Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加 warning 根组件为 <fragment> 时不支持反解 close #98 #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shirookie
Copy link
Collaborator

No description provided.

@@ -38,7 +38,12 @@ export class ANodeCompiler<T extends 'none' | 'typed'> {
if (TypeGuards.isAForNode(aNode)) return this.compileFor(aNode)
if (TypeGuards.isASlotNode(aNode)) return this.compileSlot(aNode)
if (TypeGuards.isATemplateNode(aNode)) return this.compileTemplate(aNode)
if (TypeGuards.isAFragmentNode(aNode)) return this.compileFragment(aNode)
if (TypeGuards.isAFragmentNode(aNode)) {
if (isRootElement) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

子组件根是fragment 时,不应该报warning

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太确定了,你用san实际试一下

if (TypeGuards.isAFragmentNode(aNode)) return this.compileFragment(aNode)
if (TypeGuards.isAFragmentNode(aNode)) {
if (isRootElement) {
console.warn('根元素为 <fragment> 不支持反解')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码里的报错,用简单的英文

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants